Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Reduce unnecessary resolve in type providers #656

Merged
merged 4 commits into from
Feb 27, 2023

Conversation

koxudaxi
Copy link
Owner

@koxudaxi koxudaxi commented Feb 26, 2023

This PR resolves errors of unexpected when resolving reference.

Related Issues

#504
#380
#353
#351
#326

Related commit

JetBrains/intellij-community@7aef830

@codecov
Copy link

codecov bot commented Feb 26, 2023

Codecov Report

Base: 73.74% // Head: 73.32% // Decreases project coverage by -0.42% ⚠️

Coverage data is based on head (96b556f) compared to base (1f34d0d).
Patch coverage: 58.33% of modified lines in pull request are covered.

Additional details and impacted files
@@            Coverage Diff             @@
##           master     #656      +/-   ##
==========================================
- Coverage   73.74%   73.32%   -0.42%     
==========================================
  Files          24       24              
  Lines        1889     1856      -33     
  Branches      589      587       -2     
==========================================
- Hits         1393     1361      -32     
- Misses        199      208       +9     
+ Partials      297      287      -10     
Impacted Files Coverage Δ
...koxudaxi/pydantic/PydanticDataclassTypeProvider.kt 41.02% <28.57%> (-26.37%) ⬇️
src/com/koxudaxi/pydantic/PydanticTypeProvider.kt 76.19% <77.27%> (+0.62%) ⬆️

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report at Codecov.
📢 Do you have feedback about the report comment? Let us know in this issue.

@koxudaxi koxudaxi merged commit 20d346a into master Feb 27, 2023
@koxudaxi koxudaxi deleted the Reduce_unnecessary_resolve_in_type_providers branch February 27, 2023 08:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant